feat(dal,sdf): Auto-enqueue update functions for impacted components #5511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dependency Review✅ No vulnerabilities or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Files |
github-actions
bot
added
A-sdf
britmyerss
commented
Feb 19, 2025
| // potentially needing an update action | ||
| // NOTE: We have no way to guarantee that a component's value will actually be different after DVU | ||
| // so for now, just enqueue if the value is enqueued to change. More work here is likely needed | ||
| let dependency_graph = DependentValueGraph::new( |
There was a problem hiding this comment.
this can likely be refined to look for updates only to domain, or something to that effect, but as it's behind a flag, we can iterate here to work out the permutations
There was a problem hiding this comment.
actually I'm changing this up now. stay tuned.
britmyerss
commented
Feb 19, 2025
| @@ -231,11 +231,8 @@ async fn auto_queue_creation(ctx: &mut DalContext) { | |||
| assert!(action_ids.is_empty()); | |||
| } | |||
|
|
|||
| // TODO This test is a stub that should be fixed after actions v2 is done | |||
For now, this is behind a feature flag as we work out the various permutations and behavior we want to see. When an attribute value is updated for a component, and the component has a resource AND an update function exists, enqueue it. Then, build a dependency graph, and if any downstream components with resources also have update functions, enqueue them as well.
britmyerss
force-pushed
the
brit/auto-enqueue-update-actions
branch
from
88b3885 to
ce1ecdb
Compare
nickgerace
reviewed
Feb 20, 2025
nickgerace
approved these changes
Feb 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For now, this is behind a feature flag as we work out the various permutations and behavior we want to see.
When an attribute value is updated for a component, and the component has a resource AND an update function exists, enqueue it. Then, build a dependency graph, and if any downstream components with resources also have update functions, enqueue them as well.
via The Comeback HBO on GIPHY